View Issue Details

IDProjectCategoryView StatusLast Update
0027768mantisbtadministrationpublic2020-12-28 09:13
Reporterbos4711 Assigned Todregad  
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.22.1 
Target Version2.25.0Fixed in Version2.25.0 
Summary0027768: When deleting a project, there should be information of how many (if any) issues are affected
Description

As above.

When deleting a project, there is zero information.

TagsNo tags attached.

Relationships

related to 0027779 closeddregad CVE-2020-35571: XSS in helper_ensure_confirmed() calls 

Activities

bos4711

bos4711

2020-12-17 01:42

reporter  

Screenshot_11.png (33,678 bytes)   
Screenshot_11.png (33,678 bytes)   
dregad

dregad

2020-12-17 10:10

developer   ~0064803

Resolved by mistake.

dregad

dregad

2020-12-17 10:24

developer   ~0064805

PR https://github.com/mantisbt/mantisbt/pull/1718

New message as per screenshot below

image.png (14,752 bytes)   
image.png (14,752 bytes)   
atrol

atrol

2020-12-17 16:40

developer   ~0064811

@dregad your current PR introduces XSS, see my note in the PR.

While thinking more about it, I am asking myself if we should sanitize the string in function helper_ensure_confirmed.
Didn't try, but seems we have already XSS in current code, e.g. have a look at the helper_ensure_confirmed call in manage_custom_field_update.php where the custom field name is not sanitized.

dregad

dregad

2020-12-28 09:13

developer   ~0064850

For the record - the fix for the XSS referenced in 0027768:0064811 is included in the commit that I just merged to master branch.

With regards to XSS in other places in code, I confirmed the suspected behavior and opened 0027779 to track.

Related Changesets

MantisBT: master 100c3d58

2020-12-19 12:06:41

dregad

Details Diff
Improve Project delete confirmation message

The 'project_delete_msg' string now includes the bug count in addition
to the Project's name.

New Project API function project_get_bug_count() returns the number
of issues associated to the given project.

Fixes 0027768
Affected Issues
0027768
mod - core/project_api.php Diff File
mod - lang/strings_english.txt Diff File
mod - manage_proj_delete.php Diff File